Modernize input handling#343
Open
lapinozz wants to merge 2 commits intoSFML:masterfrom
Open
Conversation
Contributor
Author
|
After reading previous issues and PRs it seems like the main drawback of using events only for mouse inputs instead of doing global polling is that we might not receive events if there's a transparent window/overlay on top of ours. IMO that seems like an edge case and the workaround for that is easier/cleaner than the ones for the current issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the input handling to fix some bugs and to make it more similar to imgui's own backends (mostly looked at the SDL one)
Fixes #337, #338 and #88