Remove credit charges from Errik Darksider waypoint actions#421
Remove credit charges from Errik Darksider waypoint actions#421nicolassanchez02 wants to merge 4 commits into
Conversation
As of GU 16.45 all waypoint services from herald NPCs were made free. Errik Darksider (heraldtatooine2) still had money.requestPayment() calls in each of his four waypoint action handlers, charging 50, 30, 15, and 60 credits respectively. Removed the payment calls and the now-unused dictionary params declarations, and dropped the money library import since nothing else in the script uses it. Fixes SWG-Source#248
|
is any of this getting tested or actually looked at with respect to the very obvious logical issues remaining after this change |
|
Can you point out the specific issues you're seeing? Happy to address them. |
|
read the script and tell me why removing the requestPayment call is not the only relevant logic to address in the conversation |
The initial fix only removed the requestPayment calls but left the credit balance condition functions (cashyes50/30/15/60) and their branch checks intact. This meant players with insufficient credits were still hitting the 'can't afford it' dismissal path and leaving without a waypoint, even though the service is supposed to be free since GU 16.45. Removed the four cashyes condition functions entirely as dead code and replaced all four credit-gated branch checks with _defaultCondition so every player gets the waypoint unconditionally. The 'insufficient funds' fallback branches are also removed since they can no longer be reached.
|
You're right, the first commit was incomplete. Removing requestPayment alone left the four cashyes condition functions (cashyes50/30/15/60) as dead code, and the branch handlers that call them were still gating players on credit balance checks. Anyone with less than the required credits would navigate the full conversation tree, hit the condition check, fall through to the 'can't afford it' dismissal path, and leave with no waypoint, and even though the service is supposed to be free. Updated the fix to remove the cashyes condition functions entirely and replace the credit gates in branches 8, 14, 18, and 24 with _defaultCondition so the waypoint is given unconditionally. The insufficient funds fallback paths are cleaned out as well since they're unreachable now. |
2 participants
heraldtatooine2(Errik Darksider on Tatooine) was charging players credits for waypoints: 50, 30, 15, and 60 credits depending on the destination. Every other herald NPC script in the codebase (heraldcorellia1,heraldcorellia2,heraldlok,heraldlok2,heraldnaboo,heraldnaboo2,heraldtatooine1) has no payment logic at all.heraldtatooine2was the only outlier, so this was clearly an oversight.The fix removes all credit-related logic:
money.requestPayment()callscashyescondition functions that checked player credit balance before giving a waypointimport script.library.money;statement since nothing else in the script uses itPlayers now receive waypoints unconditionally, consistent with every other herald NPC.
Closes #248