Deprecate boolean expressions#8619
Open
Phill310 wants to merge 10 commits intoSkriptLang:dev/featurefrom
Open
Conversation
…e critical state expression as deprecated
Phill310
requested review from
APickledWalrus and
erenkarakal
and removed request for
a team
skriptlang-automation
Bot
added
the
needs reviews
APickledWalrus
requested changes
May 5, 2026
Member
APickledWalrus
left a comment
APickledWalrus
left a comment
There was a problem hiding this comment.
Looking really good so far! Nice work.
Comment on lines
+32
to
+33
| "%projectile% is in (projectile|arrow) critical (state|mode)", | ||
| "%projectile% (is not|isn't) in (projectile|arrow) critical (state|mode)") |
Member
There was a problem hiding this comment.
Should be fine to support multiple projectiles. And using infoBuilder rather than manually adding the patterns should work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We have moved away from Boolean Expressions in favor of effect+condition pairs.
Solution
I looked through the expressions to find boolean expressions which could be deprecated and replaced. I then created effects and conditions to replace the functionality of the deprecated expressions.
Testing Completed
Tests will be coming soon. I wanted to get opinions on the rest of the code first.
Supporting Information
Please let me know if I missed any or if some of these don't count.
Completes: none
Related: none
AI assistance: none