Improve floating notification accessibility announcement timing#2566
Merged
kynansongwork merged 1 commit intomainfrom May 1, 2026
Merged
Conversation
Dennis Li (dennis-li-skyscanner)
added
patch
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the floating notification presentation so the VoiceOver .layoutChanged notification is posted after the “animate up” transition completes, improving the timing of the accessibility announcement.
Changes:
- Moves the
UIAccessibility.post(notification: .layoutChanged, ...)call from the animation block to the animator completion block.
| notification.bottomConstraint.constant = displayedBottomConstraintConstant | ||
| notification.superview?.layoutIfNeeded() | ||
| } | ||
| upAnimator.addCompletion { position in |
Contributor
Author
There was a problem hiding this comment.
I think an extra call is not harmful.
The code should notify the a11y engine to focus the label in all animation position
kynansongwork
approved these changes
Apr 30, 2026
kynansongwork
deleted the
sonic/SONIC-4572-floating-notification-a11y-bugfix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
FloatingNotificationAnimatorso the VoiceOver layout change notification is posted after the floating notification presentation animation completes.This ensures the notification message label is announced once the notification has finished moving into its displayed position.
Before
ScreenRecording_04-30-2026.14-32-51_1.MP4
After
ScreenRecording_04-30-2026.14-31-57_1.MP4
Remember to include the following changes:
README.md- Not applicable; no documentation or API changes.Backpack.hheader file - Not applicable; no new component.