Preserve identity on Probe.copy()#428
Open
h-mayorquin wants to merge 1 commit intoSpikeInterface:mainfrom
Open
Preserve identity on Probe.copy()#428h-mayorquin wants to merge 1 commit intoSpikeInterface:mainfrom
Probe.copy()#428h-mayorquin wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #421.
Probe.copy()was droppingcontact_ids,shank_ids,contact_sides,annotations, andcontact_annotations; the only exclusion that was ever intentional isdevice_channel_indices(wiring, not identity). I fixed it by routingcopy()through the existingto_dict/from_dictpair, which is already the canonical enumeration of a probe's serializable state via_dump_attr_names, and poppingdevice_channel_indicesfrom the intermediate dict. This gives one source of truth for what a probe "is" and means any attribute added to_dump_attr_nameslater will automatically round-trip throughcopy().