1st crack at re-writing rationale section of TCW31 (update p5subset in Styleseets)#28
Merged
trishaoconnor merged 2 commits intomasterfrom Jan 13, 2026
Merged
1st crack at re-writing rationale section of TCW31 (update p5subset in Styleseets)#28trishaoconnor merged 2 commits intomasterfrom
trishaoconnor merged 2 commits intomasterfrom
Conversation
ebeshero
requested changes
Dec 7, 2025
| bar*</code>, the test would fail.</p> | ||
| </div> | ||
| <div> | ||
| <head>solution</head> |
| in the TEI repository does <hi rend="italics">not</hi> put a | ||
| new copy of p5subset.xml into the | ||
| <code>Stylesheets/source/</code> directory. The file needs | ||
| to be manually copied over, hence these instructions for |
Member
There was a problem hiding this comment.
(At least that is the state of things right now. It really seems strange that we don’t have an automatic process that either moves the built file to Stylesheets or just looks for the built P5 in place. The more I think of it, the more sensible it seems to find a way to automate this with no need for manual copying of files.)
That is just a comment looking forward to yet another revision of this documentation, not suggesting any change here—unless some brief mention of discussions to change all this for the better.
sydb
changed the title
trishaoconnor
approved these changes
Jan 13, 2026
Contributor
trishaoconnor
left a comment
trishaoconnor
left a comment
There was a problem hiding this comment.
Thank you @Syd for your changes to the Rationale section. The examples you mention are especially helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.