fix(ui5-select): correct dropdown button height#13408
Open
NakataCode wants to merge 1 commit intomainfrom
Open
fix(ui5-select): correct dropdown button height#13408NakataCode wants to merge 1 commit intomainfrom
NakataCode wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
🚀 Deployed on https://pr-13408--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dropdown button height was set to calc(100% - 0.0625rem) in
sap_horizonandsap_horizon_darkthemes, causing a 1px vertical misalignment with the input field. According to the Input with Button (Horizon) spec, the button height should match the field height exactly (2.25rem cozy, 1.625rem compact). Set--_ui5_select_icon_wrapper_heightand--_ui5_select_icon_wrapper_state_heightto 100% to align with the specification.Additionally, the field's bottom border (inset box-shadow) was covered by the dropdown button's hover background. Per spec, the field's underline must appear on top of the button in all states. Fixed by drawing the bottom border as a background-image gradient on the select root element, spanning the full width including under the button, and setting the button hover background to transparent so the gradient remains visible.
Fixes: #13306