Skip to content

hotfix: 서버에서 ssr api swagger로 확인하기 위해 스펙추가#395

Merged
jickDo merged 4 commits intodevfrom
feature/391-course-detail-to-thymeleaf
Sep 18, 2025
Merged

hotfix: 서버에서 ssr api swagger로 확인하기 위해 스펙추가#395
jickDo merged 4 commits intodevfrom
feature/391-course-detail-to-thymeleaf

Conversation

@jickDo
Copy link
Copy Markdown
Contributor

@jickDo jickDo commented Sep 18, 2025

서버에서 ssr api swagger로 확인하기 위해 스펙추가

@jickDo jickDo self-assigned this Sep 18, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

기존 Thymeleaf 기반 코스 뷰 컨트롤러에 대한 명세 인터페이스 CourseThymeleafSpec가 추가되었고, 구현 클래스 CourseThymeleaf가 해당 인터페이스를 구현하도록 시그니처가 변경되었다. 메서드 본문 및 제어 흐름 변경은 없다.

Changes

Cohort / File(s) Change Summary
Spec 인터페이스 추가
src/main/java/com/unretired/core/course/api/spec/CourseThymeleafSpec.java
새로운 공개 인터페이스 CourseThymeleafSpec 추가. OpenAPI 어노테이션 및 Spring Model 사용. 메서드 String showCourse(Model model) 선언.
구현 클래스 시그니처 변경
src/main/java/com/unretired/core/course/api/CourseThymeleaf.java
클래스 선언을 implements CourseThymeleafSpec로 변경. 관련 스펙 import 추가. 기존 메서드 구현 및 로직 변화 없음.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between bfa6697 and 2aa40bd.

📒 Files selected for processing (2)
  • src/main/java/com/unretired/core/course/api/CourseThymeleaf.java (2 hunks)
  • src/main/java/com/unretired/core/course/api/spec/CourseThymeleafSpec.java (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@jickDo jickDo merged commit 3aff772 into dev Sep 18, 2025
1 of 2 checks passed
jickDo added a commit that referenced this pull request Sep 18, 2025
* feat: 임시 코스 상세 불러오기 ssr버전

* feat: 줄간격 및 줄 정렬 변경

* fix: 운영서버에서 api spec 확인을 위한 스펙정의
jickDo added a commit that referenced this pull request Sep 18, 2025
* hotfix: 서버에서 ssr api swagger로 확인하기 위해 스펙추가 (#395)

* feat: 임시 코스 상세 불러오기 ssr버전

* feat: 줄간격 및 줄 정렬 변경

* fix: 운영서버에서 api spec 확인을 위한 스펙정의

* hotfix: 특정 컨트롤러 스캔 테스트 (#397)

* feat: 임시 코스 상세 불러오기 ssr버전

* feat: 줄간격 및 줄 정렬 변경

* fix: 운영서버에서 api spec 확인을 위한 스펙정의

* fix: prod로 향하는 에러로그
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant