Don't call again_or_timeout on the success path#44
Open
pacujo wants to merge 1 commit intoWithSecureOpenSource:masterfrom
Open
Don't call again_or_timeout on the success path#44pacujo wants to merge 1 commit intoWithSecureOpenSource:masterfrom
pacujo wants to merge 1 commit intoWithSecureOpenSource:masterfrom
Conversation
On the success path, errno may contain a stale EAGAIN, causing again_or_timeout to advance timer_state from EXPIRED to REPORTED. A subsequent http_op_get_response_content call checks timer_state first and returns ETIMEDOUT if it sees REPORTED -- even though the response headers were received successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the success path, errno may contain a stale EAGAIN, causing again_or_timeout to advance timer_state from EXPIRED to REPORTED. A subsequent http_op_get_response_content call checks timer_state first and returns ETIMEDOUT if it sees REPORTED -- even though the response headers were received successfully.