Conversation
Addon (DataToColor v1.9.7): - Derive initPhase from FRAME_CHANGE_RATE (2 * 5 = 10) instead of a hardcoded magic number, keeping the Lua and C# thresholds in sync. - Ensure globalTime is at least initPhase before the first render pass so queue data written during early frames is not discarded by the C# FullReset check on the very first visible frame. Core (AddonReader): - Replace the hardcoded FullReset guard (GlobalTime.Value <= 3) with AddonTicks.INIT_PHASE, a named constant derived from the same GLOBAL_QUEUE_UPDATE cadence used by the addon. - Track previousGlobalTime to detect time wraparound / addon reload and trigger a FullReset when globalTime decreases. Core (TargetPetTargetGoal): - Add bits.PetTarget_Alive() check to CanRun() so the goal does not fire when the pet's target is dead, preventing the Succubus (or any defensive pet) from looping on a corpse. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Xian55
changed the title
Xian55
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FullResetthreshold was a hardcoded magic number (<= 3) that didn't align with the LuainitPhase. Queue data sent during early frames could be missed becauseglobalTimewasn't past the reset threshold when rendering started. Now both sides derive the threshold fromFRAME_CHANGE_RATE/GLOBAL_QUEUE_UPDATE, andAddonReaderalso detects time wraparound (addon reload) viapreviousGlobalTime.TargetPetTargetGoal.CanRun()didn't checkPetTarget_Alive(), causing the Succubus (or any defensive pet) to loop on a corpse target. Added the alive guard.Addon version bumped from 1.9.6 to 1.9.7.
Test plan
FullResetfires once during init phase and addon frames render correctly after/reloadin-game — verifyFullResettriggers on time wraparound (globalTime decreases)🤖 Generated with Claude Code