Open
Conversation
Removes ServerContext from being passed around since a tserver object is already set within the logger. Also removed a reference to a VolumeManager that was not being used.
dlmarion
approved these changes
Apr 8, 2026
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
I think the changes are good, but I'm not sure we want to log stack traces on these warnings.
| // ignore | ||
| } catch (IOException | RuntimeException ex) { | ||
| log.error("Unable to cleanly close log " + currentLog.getLogEntry() + ": " + ex, ex); | ||
| log.error("Unable to cleanly close log {}: {}", currentLog.getLogEntry(), ex, ex); |
Contributor
There was a problem hiding this comment.
I think the first ex can just be removed. This is going to log the entire stack trace.
| return HostAndPort.fromString(managers.iterator().next().toHostPortString()); | ||
| } catch (Exception e) { | ||
| log.warn("Failed to obtain manager host " + e); | ||
| log.warn("Failed to obtain manager host", e); |
Contributor
There was a problem hiding this comment.
If this prints the entire stack trace, then I think this is a behavior change. Previously this would print Exception.toString, not the entire stack trace. Suggest adding a placeholder to the message {}.
| return new TServerInstance(getAdvertiseAddress().toString(), lockSessionId); | ||
| } catch (Exception ex) { | ||
| log.warn("Unable to read session from tablet server lock" + ex); | ||
| log.warn("Unable to read session from tablet server lock", ex); |
Contributor
There was a problem hiding this comment.
Same comment here about behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes log message formats.
Removes serverContext from method signatures where they aren't needed.
Removes unused VolumeManager from method signature.