UnsafeAppendBoolToBitmap for dictionary and REE builders#758
Open
serramatutu wants to merge 2 commits intoapache:mainfrom
Open
UnsafeAppendBoolToBitmap for dictionary and REE builders#758serramatutu wants to merge 2 commits intoapache:mainfrom
UnsafeAppendBoolToBitmap for dictionary and REE builders#758serramatutu wants to merge 2 commits intoapache:mainfrom
Conversation
serramatutu
force-pushed
the
serramatutu/UnsafeAppendBoolToBitmap-ree
branch
from
c2b7711 to
374a42f
Compare
serramatutu
changed the title
UnsafeAppendBoolToBitmap for dictionary and REE buildersUnsafeAppendBoolToBitmap for dictionary and REE builders
For more context: https://github.com/apache/arrow-go/pull/558/changes#r2758798540 This commit makes `UnsafeAppendBoolToBitmap()` and `RunEndEncodedBuilder` panic. The current implementation pulled from `arrow/array/builder.go` would leave the builder in an invalid state that would panic when trying to finish a record batch.
This commit adds a proper implementation of `UnsafeAppend` and `UnsafeAppendBoolToBitmap` to the dictionary-encoded array builder. This allows using `Reserve(n)` followed by `n` calls to `UnsafeAppend` or `UnsafeAppendBoolToBitmap`. I also added a test to it.
serramatutu
force-pushed
the
serramatutu/UnsafeAppendBoolToBitmap-ree
branch
from
374a42f to
4551ae0
Compare
serramatutu
changed the title
UnsafeAppendBoolToBitmap for dictionary and REE buildersUnsafeAppendBoolToBitmap for dictionary and REE builders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
For more context: https://github.com/apache/arrow-go/pull/558/changes#r2758798540
The Builders for REE and dict-encoded arrays were inheriting the
UnsafeAppendBoolToBitmap()andUnsafeAppend()from theBuilderinterface defined inarrow/array/builder.go. The default implementation does not bump the length of the inneridxBuilderorrunEndsBuilder, which causes it to be in an inconsistent state where the parent has greater length than the index/run-ends builder. This causes a panic when instancing a record batch.What changes are included in this PR?
This PR makes
UnsafeAppendBoolToBitmap()forRunEndEncodedBuilderpanic as there is not a good semantic meaning for this method in case of REE.It also implements
UnsafeAppendBoolToBitmap()andUnsafeAppend()for the Dictionary builders. This allows users to usebldr.Reserve(n)followed byncalls toUnsafeAppend()orUnsafeAppendBoolToBitmap()without the need to check if the array needs to grow everytime.Are these changes tested?
Yes.
Are there any user-facing changes?
No. The API was already there (inherited from
Builder), but the behavior was incorrect.