[common] Fix ArrayIndexOutOfBoundsException in .toArray() methods

[binary-signal]

Linked issue: close #2157

Purpose

Fix incorrect targetOffset usage in BinaryArray’s to*Array() methods.

Previously, these methods passed UNSAFE.arrayBaseOffset(...) constants (e.g., DOUBLE_ARRAY_OFFSET) to BinarySegmentUtils.copyToUnsafe(). These values represent raw memory offsets (typically ~16 bytes on 64-bit JVMs), while copyToUnsafe() expects a standard 0-based Java array index.

This mismatch caused writes to start at an incorrect position in the target array, leading to:

• ArrayIndexOutOfBoundsException
• Corrupted results during round-trip conversions

For example, with a 20-element double array:

• targetOffset ≈ 16
• Writes occur from target[16] to target[35]
• Resulting in: `ArrayIndexOutOfBoundsException: Index 20 out of bounds for length 20

Brief change log

• BinaryArray.java

  • Replaced all UNSAFE.arrayBaseOffset(...) constants with 0 for the targetOffset parameter in:
    • toBooleanArray
    • toByteArray
    • toShortArray
    • toIntArray
    • toLongArray
    • toFloatArray
    • toDoubleArray

• BinaryArrayTest.java

  • Added round-trip tests for all primitive array types to ensure correctness

Tests

Added the following round-trip tests:

• testRoundTripToBooleanArray
• testRoundTripToByteArray
• testRoundTripToShortArray
• testRoundTripToIntArray
• testRoundTripToLongArray
• testRoundTripToFloatArray
• testRoundTripToDoubleArray

API & Compatibility

• No API changes
• No storage format changes

[binary-signal]

@wuchong could you please have a look when you have time

[binary-signal]

@fresh-borzoni @luoyuxia PTAL 🙏

[fresh-borzoni]

@binary-signal TY, LGTM 👍 verified the fix locally

nit: worth adding an empty-array test (e.g. new double[0]) for at least one primitive.

[binary-signal]

Thanks for the review @fresh-borzoni, I will also add the empty array test

[binary-signal]

addressed comment

[polyzos]

LGTM