Knox IDF - First steps#1215
Draft
smolnar82 wants to merge 6 commits intoapache:knox_idffrom
Draft
Conversation
Test Results21 tests 21 ✅ 1s ⏱️ Results for commit be983fe. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Knox becomes an OIDC Provider itself. Until this change it was participating OIDC flows as a Service Provider only through the pac4j federation filter.
This PR is driven by KIP-18.
How was this patch tested?
Manually tested the
Integration Tests
TODO
UI changes
The login page has been updated in a way such that it lists all pre-configured federated OPs, if any.