opa polaris authorizer: resolve authz inputs using scoped resolution; block unsupported operations#4398
Draft
gracechen09 wants to merge 2 commits into
Draft
opa polaris authorizer: resolve authz inputs using scoped resolution; block unsupported operations#4398gracechen09 wants to merge 2 commits into
gracechen09 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is phase 6 of #3779.
Change 1: Resolve authz inputs using scoped resolution
Before the change, OPA authorizer called
manifest.resolveAll(), which resolves the caller principal, all principal roles and all requested paths. OPA authorizer authorizes based onPolarisSecurableintent in AuthorizationRequest and doesn't use resolved principal or role entities.After the change,
resolveAuthorizationInputs()callsmanifest.resolveSelections()with the input that OPA needs.Change 2: Block unsupported operations
Before the change,
authorize()handled all the operations.After the change,
authorize()blocks the operations that target theprincipal,principal_roleandcatalog_roleentity types. When using OPA, principals and roles are expected to be managed externally, therefore OPA should not handle the authorization from Polaris principal management API.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)