Move Iceberg request.validate() to the REST adapter#4423
Open
flyrain wants to merge 1 commit into
Open
Conversation
Run request.validate() once at the top of IcebergCatalogAdapter methods (createTable, updateProperties, registerTable, createView) instead of inside the handler/util layer. Validation now happens before authorization, which is cheaper and gives clearer errors for malformed payloads. Also collapses two validate() calls in the createTable flow (direct + staged paths) into one at the boundary.
dimas-b
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why do we need this change:
resolution, role/grant checks). Doing validate first means malformed requests don't burn auth work. Also gives clearer errors: a user sending a bad payload now gets "invalid request," not "forbidden."
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)