Port Clojure tests to Java: versioned_store_test and tuple_test#8443
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rzo1
reviewed
Mar 28, 2026
VersionedStore.createVersion() already handles same-millisecond collisions by incrementing the version number, so no sleep is needed between version creations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rzo1
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
See #8445
Storm was originally written in Clojure. The core was rewritten in Java, but ~5,000 lines of Clojure integration tests remain in
storm-core/test/clj/(107 test functions across 13 files). These are the main reason the Clojure dependency (1.12.4, carbonite, tools.logging, clojure-maven-plugin, shade transformer) is still in the build. Porting them to Java enables full removal of the Clojure stack.The Java testing infrastructure is already mature:
Testing.javaprovides 33 public methods (completeTopology,readTuples,multiseteq,withSimulatedTime, etc.), and JUnit 5, Mockito 5.14, and Awaitility 4.3 are all available. 48 Java test files already exist understorm-server/src/test/.Summary
First phase of porting Clojure tests to Java to enable eventual removal of the
Clojure dependency. Ports 8 test functions from 2 Clojure files to Java/JUnit 5.
Changes
storm-core/test/clj/org/apache/storm/versioned_store_test.cljstorm-core/test/jvm/org/apache/storm/utils/VersionedStoreTest.javastorm-core/test/clj/org/apache/storm/trident/tuple_test.cljstorm-core/test/jvm/org/apache/storm/trident/TridentTupleViewTest.javaNot ported:
serialization_test.clj(1 test) — only tests Clojure-specific datatypes (keywords, sets, maps) that won't exist after Clojure removal. The existing
Java
SerializationTestalready covers Java type roundtrips.Context
This is Phase 1 of an 8-phase plan to port all ~107 Clojure test functions to Java,
enabling full removal of the
storm-clojure,storm-clojure-testmodules and theClojure build dependency. The Clojure test files are not deleted yet — that happens
in the final cleanup phase after all tests are ported.
Test plan
mvn test -pl storm-core -Dtest="VersionedStoreTest,TridentTupleViewTest"— 8 tests, all pass🤖 Generated with Claude Code