Add Salim+18 modified Calzetti attenuation law (δ, B) with end-to-end ProSpect integration#29
Draft
Add Salim+18 modified Calzetti attenuation law (δ, B) with end-to-end ProSpect integration#29
Conversation
Agent-Logs-Url: https://github.com/asgr/ProSpect/sessions/8b729933-6d67-4e6c-bc24-c4dedbae417f Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/asgr/ProSpect/sessions/8b729933-6d67-4e6c-bc24-c4dedbae417f Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Salim+18 attenuation law implementation to ProSpect
Add Salim+18 modified Calzetti attenuation law (δ, B) with end-to-end ProSpect integration
Apr 16, 2026
Owner
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Contributor
Author
Resolved the merge conflicts and merged the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the Salim et al. (2018) modified Calzetti attenuation law so ProSpect can model flexible dust-screen curves via slope tilt (δ) and UV bump strength (B), instead of assuming a single fixed screen law.
Dust law implementation (
R/dust.R)Salim18_screen(...)for modified Calzetti attenuation.screen_atten(...)dispatch wrapper (dust_law = "CF" | "Salim18").CF_screen_atten(...)andatten_emit(...)to accept law-selection and Salim+18 parameters (delta,B,Rv) while preserving existing CF defaults.High-level API wiring (
R/SFH.R,R/ProSpect.R)SFHfunc,SFHburst, andProSpectSED:dust_law = "CF"delta_screen = 0B_screen = 0Rv_screen = 4.05CF_screen(...)usage in screen paths withscreen_atten(...).atten_emit(...).Documentation updates (
man/*.Rd)man/dust.Rdman/SFH.Rdman/ProSpectSED.RdTargeted regression/behavior coverage
tests/test_salim18_dust.Rvalidating:Eb -> Bfallback handling in Salim18 mode.