docs(readme): update minimum Node.js version requirement from v16 to v18#121
Open
ygd58 wants to merge 1 commit intobase:masterfrom
Open
docs(readme): update minimum Node.js version requirement from v16 to v18#121ygd58 wants to merge 1 commit intobase:masterfrom
ygd58 wants to merge 1 commit intobase:masterfrom
Conversation
1dbea53 to
a98c720
Compare
Author
|
hey @soheimam @youssefea can you take a look when you get a chance? |
a98c720 to
d35ea0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README says Node.js v16 is the minimum but the project actually requires v18. Node 16 hit end of life in September 2023 so anyone following the README and installing v16 will run into issues.