Skip to content

feat(staged): add General settings page with theme selector and auto-review toggle#644

Merged
matt2e merged 15 commits intomainfrom
general-settings
Apr 23, 2026
Merged

feat(staged): add General settings page with theme selector and auto-review toggle#644
matt2e merged 15 commits intomainfrom
general-settings

Conversation

@matt2e
Copy link
Copy Markdown
Contributor

@matt2e matt2e commented Apr 21, 2026

Summary

  • Add a new General settings page with theme search/selector (moved from the top bar) and an "Auto start code reviews" toggle
  • Clean up settings sidebar by removing "Sections" header and renaming "Repo" to "Repos"
  • Fix a11y warning for label not associated with a form control

Test plan

  • Verify the General settings page loads with the theme selector and auto-review toggle
  • Confirm theme selection works from the new settings page
  • Verify the top bar no longer shows the theme button
  • Check that the "Auto start code reviews" toggle persists its setting
  • Confirm settings sidebar shows correct labels

🤖 Generated with Claude Code

@matt2e matt2e requested review from baxen and wesbillman as code owners April 21, 2026 09:14
matt2e and others added 7 commits April 23, 2026 09:34
…and renaming "Repo" to "Repos"

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…e theme button from top bar

Move the theme picker from the top bar dropdown into a new "General"
settings section, making it the default landing page when opening settings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add a new preference that controls whether code reviews are
automatically triggered after commits. Users can choose between
"Never" and "After changes" (default). The Rust session runner
reads this preference from the persistent store before triggering
auto-reviews.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ix a11y warning

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The theme picker was rendered as a search input with a scrollable button
list. Replace it with a native <select> dropdown for a more standard UI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cache the sq availability check with OnceLock for the process lifetime
and use it as the default for auto-review in both the Rust session
runner and the frontend preferences initialization.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ix clippy

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@matt2e matt2e force-pushed the general-settings branch from aee0f39 to 020aaf1 Compare April 22, 2026 23:37
matt2e and others added 8 commits April 23, 2026 09:41
…info icon

Swap the FormToggle for a native <select> dropdown to match the theme
picker style, and add a lucide Info icon next to the description text.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Each theme row now shows the theme name in its foreground color on its
actual background, with a "// preview" comment in the theme's comment
color. The active theme gets a colored border and checkmark.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…text

Move the color-swatch theme list behind a dropdown trigger button that
shows the current theme as a mini swatch. Remove the "// preview" text
from each row.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add filter buttons at the top of the theme swatch dropdown to let users
filter themes by appearance (All, Light, Dark) using isLightTheme().

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…behaviour"

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…string, unknown>

TypeScript rejects direct casts between ThemeRegistrationRaw and
Record<string, unknown> because the types don't sufficiently overlap.
Extract a rawObj variable cast via unknown to fix the type errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@matt2e matt2e merged commit 39dd4cc into main Apr 23, 2026
6 checks passed
@matt2e matt2e deleted the general-settings branch April 23, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant