core: tools: nginx: Add a 404 if extension is not registered#3905
Merged
Williangalvani merged 1 commit intobluerobotics:masterfrom Apr 28, 2026
Merged
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
error_page 404 = @extension_not_found;directive in the/extensionv2/location is never used because thereturn 404;immediately exits; either remove theerror_page/named location or move the JSON response directly into the main location block.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `error_page 404 = @extension_not_found;` directive in the `/extensionv2/` location is never used because the `return 404;` immediately exits; either remove the `error_page`/named location or move the JSON response directly into the main location block.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
Member
|
@patrickelectric I believe this PR is a good defensive measure, but it doesn't fulfill the needs of #3904? |
Member
Just tested and it actually does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #3904
Summary by Sourcery
Bug Fixes: