mir::Synchronised: propagate noexcept to the construtor when possible#4925
Open
RAOF wants to merge 1 commit into
Open
mir::Synchronised: propagate noexcept to the construtor when possible#4925RAOF wants to merge 1 commit into
noexcept to the construtor when possible#4925RAOF wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates mir::Synchronised<T> to conditionally mark its rvalue-initializing constructor noexcept when the contained T can be constructed without throwing, improving exception guarantees for callers and enabling better optimizations in generic code.
Changes:
- Add
<type_traits>to support compile-timenoexceptconditions. - Make
Synchronised(T&&)conditionallynoexcept(...)based onT’s construction traits.
| public: | ||
| Synchronised() = default; | ||
| Synchronised(T&& initial_value) | ||
| Synchronised(T&& initial_value) noexcept(std::is_nothrow_move_constructible_v<T>) |
Contributor
Author
There was a problem hiding this comment.
This is incorrect; std::is_nothrow_move_constructible_v<T> is documented to be the equivalent of std::is_nothrow_constructible_v<T, T&&> (or, rather, std::add_rvalue_reference<T>) anyway.
RAOF
force-pushed
the
tiny-synchronised-improvement
branch
from
8f58a45 to
0bd05f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.