Add pre-push git hook for symbol checks and code review#4933
Draft
tarek-y-ismail wants to merge 5 commits into
Draft
Add pre-push git hook for symbol checks and code review#4933tarek-y-ismail wants to merge 5 commits into
tarek-y-ismail wants to merge 5 commits into
Conversation
- Introduce .githooks/pre-push to enforce ABI symbol checks before push - Optionally run Claude-based code review if copilot CLI is available - Document git hooks setup and usage in HACKING.md - Provide instructions for skipping or running hooks manually
Saviq
reviewed
May 7, 2026
Saviq
reviewed
May 7, 2026
Saviq
reviewed
May 7, 2026
Co-authored-by: Michał Sawicz <michal.sawicz@canonical.com>
Co-authored-by: Michał Sawicz <michal.sawicz@canonical.com>
Both environment variables now follow the same naming convention: - MIR_SKIP_SYMBOL_CHECK=true Skip symbol checks - MIR_SKIP_CODE_REVIEW=true Skip code review This makes the hook options more consistent and intuitive - both use negative logic (skip) rather than mixing positive and negative patterns. Default behavior is preserved: code review still runs unless explicitly disabled with MIR_SKIP_CODE_REVIEW=true. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new?
How to test
HACKING.mdfor instructions.Checklist