DecorationProvider example: Allow for scale when sizing background text#4941
Open
AlanGriffiths wants to merge 1 commit into
Open
DecorationProvider example: Allow for scale when sizing background text#4941AlanGriffiths wants to merge 1 commit into
AlanGriffiths wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DecorationProvider example’s help-text rendering so the font sizing is no longer artificially constrained on HiDPI displays, aiming to make the on-background instructions more readable when output scaling is in use.
Changes:
- Add a
BackgroundInfo::buffer_scale()accessor (currently unused). - Remove the fixed
20-pixel cap from the FreeType pixel-size calculation used for help text.
AlanGriffiths
force-pushed
the
fix-text-scale-in-decorations-provider
branch
from
872a37d to
84f749b
Compare
AlanGriffiths
force-pushed
the
fix-text-scale-in-decorations-provider
branch
from
84f749b to
b58f0bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With HIDPI screens limiting the maximum number of physical pixels a character can take is annoying: the text is small.