Organized code#86
Open
yichizhang wants to merge 4 commits intochrismiles:masterfrom
Open
Conversation
…sage and title. Put them in two separate methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding accessibilityHint when initializing with title and message. (previous version only adds accessibility information in "initWithMessage:")
Organized methods in implementation file, used pragma mark to put methods into different groups.
There is a bit of repeating when calculating the bounding size of message and title. Put them into two separate methods.
Changed a spelling mistake. ( 'timeInvertal' -> 'timeInterval' )
Changed 'colourHL' variable to 'colorHL'. (should use American spelling when coding)