renamed std::text::start_with function#332
Merged
raphael-goetz merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the text runtime function definition from std::text::start_with to std::text::starts_with to align naming with std::text::ends_with and the implementation naming (per Issue #331).
Changes:
- Added a new runtime function definition file for
std::text::starts_with. - Removed the old
std::text::start_withruntime function definition file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| definitions/standard/runtime_functions/text/std_text_starts_with.proto.json | New definition for the renamed starts_with runtime function. |
| definitions/standard/runtime_functions/text/std_text_start_with.proto.json | Removes the old start_with definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicosammito
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #331