added definition source and mapping on send#146
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for propagating a definition_source value when FlowUpdateService sends definitions to Aquila, addressing Issue #144 (“DataTypeService should set definition_source”).
Changes:
- Added an optional
definition_sourcefield toFlowUpdateServiceplus a builder-style setter. - Applied
definition_sourceonto DataTypes, FunctionDefinitions, RuntimeFunctionDefinitions, and FlowTypes prior to sending. - Changed
send/send_with_status(and internal update methods) to take&mut selfto allow mutation before request construction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for function in self.functions.iter_mut() { | ||
| function.definition_source = source.to_string(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
There’s an unnecessary trailing semicolon after the if let Some(source) = ... block. It doesn’t change behavior, but it’s inconsistent with the other update methods and can look like an accidental empty statement; removing it would improve readability.
| }; | |
| } |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Resolves: #144