Skip to content

feat: add spacebar hold for 2x speed in player with proper listener c… #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
i-amansharma07 wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −10
Open

feat: add spacebar hold for 2x speed in player with proper listener c… #1923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions src/components/VideoPlayer2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,9 @@ export const VideoPlayer: FunctionComponent<VideoPlayerProps> = ({
return;
}
let volumeSetTimeout: ReturnType<typeof setInterval> | null = null;
let isSpaceHeld = false;
let previousPlaybackRate = 1;

const handleKeyPress = (event: KeyboardEvent) => {
const isShiftPressed = event.shiftKey;
const isModifierPressed = event.metaKey || event.ctrlKey || event.altKey;
Expand Down Expand Up @@ -440,15 +443,18 @@ export const VideoPlayer: FunctionComponent<VideoPlayerProps> = ({
}

switch (event.code) {
case 'Space': // Space bar for play/pause
if (player.paused()) {
player.play();
event.stopPropagation();
} else {
player.pause();
event.stopPropagation();
}
case 'Space': // Space bar for 2x speed hold
event.preventDefault();
if (event.repeat) {
if (!isSpaceHeld) {
isSpaceHeld = true;
previousPlaybackRate = player.playbackRate();
player.playbackRate(2);
if (player.paused()) {
player.play();
}
}
}
break;
case 'ArrowRight': // Right arrow for seeking forward 5 seconds
player.currentTime(player.currentTime() + 5);
Expand Down Expand Up @@ -558,16 +564,26 @@ export const VideoPlayer: FunctionComponent<VideoPlayerProps> = ({
break;
}
};
const handleKeyUp = (event: any) => {
const handleKeyUp = (event: KeyboardEvent) => {
if (event.code === 'KeyT') {
player.playbackRate(1);
}
if (event.code === 'Space') {
event.preventDefault();
if (isSpaceHeld) {
isSpaceHeld = false;
player.playbackRate(previousPlaybackRate);
return;
}
player.paused() ? player.play(): player.pause()
}
};
document.addEventListener('keydown', handleKeyPress, { capture: true });
document.addEventListener('keyup', handleKeyUp);
// Cleanup function
return () => {
document.removeEventListener('keydown', handleKeyPress);
document.removeEventListener('keydown', handleKeyPress, { capture: true });
document.removeEventListener('keyup', handleKeyUp);
};
}, [player]);

Expand Down