chore: regenerate CRAP baseline after scan target feature merge#504
Open
marcusburghardt wants to merge 1 commit into
Open
chore: regenerate CRAP baseline after scan target feature merge#504marcusburghardt wants to merge 1 commit into
marcusburghardt wants to merge 1 commit into
Conversation
The scan target feature (eeaffe5) added branching logic to scanCmd, run, and scanPolicy in cmd/complyctl/cli/scan.go. The CRAP baseline was not updated at merge time, causing CI regressions: - scanCmd: 11.25 -> 12.99 (flag completion + positional arg) - run: 4 -> 7 (target resolution branches, 100% coverage) - scanPolicy: 10.40 -> 16.06 (target filtering + generation scoping) All scores remain under the 30 threshold. run already has 100% coverage; scanPolicy coverage improvement requires dependency injection refactoring (tracked separately). Signed-off-by: Marcus Burghardt <marcus.burghardt@gmail.com> Assisted-by: OpenCode (claude-opus-4-6)
Contributor
Author
|
Thanks @gvauter and @sonupreetam . Just saw there is a conflict to be resolved and this will likely require your approvals again. :( I ping you once I can work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerate
.gaze/baseline.jsonto capture the CRAP score changes introduced by the scan target feature (eeaffe5b). The baseline was not updated at merge time, causing CRAP Load CI failures on subsequent PRs (e.g., #479).Regressions Captured
All in
cmd/complyctl/cli/scan.go, introduced by the positional target argument feature:scanCmd(*scanOptions).run(*scanOptions).scanPolicyAll scores remain under the CRAP threshold of 30. No new function violations.
Why baseline update (not tests)
runalready has 100% coverage — CRAP increase is purely from added complexityscanCmduncovered paths are Cobra boilerplate (flag registration error handling)scanPolicycoverage improvement requires dependency injection refactoring (calls package-level functionsloadProviders,resolveVersionAndGraphdirectly) — tracked as a separate effortVerification