feat/lottie by hextion · Pull Request #2035 · core-ds/core-components

hextion · 2026-02-02T08:36:15Z

No description provided.

changeset-bot · 2026-02-02T08:36:22Z

🦋 Changeset detected

Latest commit: 063cd8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@alfalab/core-components	Minor
@alfalab/core-components-lottie	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-02-02T08:39:17Z

Bundle size report

Entry point	Size (minified)
@alfalab/core-components-lottie/index.js	171.8 (+171.80 KB ❌)

coveralls · 2026-02-02T08:42:00Z

Coverage Report for CI Build 24834735888

Coverage remained the same at 81.985%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	11606
Covered Lines:	9596
Line Coverage:	82.68%
Relevant Branches:	2177
Covered Branches:	1704
Branch Coverage:	78.27%
Branches in Coverage %:	Yes
Coverage Strength:	230.44 hits per line

💛 - Coveralls

github-actions · 2026-02-02T08:52:58Z

Demo build

https://core-ds.github.io/core-components/2035

github-actions · 2026-02-06T07:38:30Z

Demo build (default)

https://core-ds.github.io/core-components/2035

github-actions · 2026-02-06T07:44:28Z

Demo build (alfasans)

https://core-ds.github.io/core-components/2035-alfasans

github-actions · 2026-03-02T13:20:55Z

Snapshot release (default)

Successfully released the following packages:

@alfalab/core-components-lottie@1.0.0-1960cb50f1bb912c4c88a4e9041989958f542451
@alfalab/core-components@50.6.0-1960cb50f1bb912c4c88a4e9041989958f542451

github-actions · 2026-03-02T14:00:27Z

Snapshot release (alfasans)

Successfully released the following packages:

@alfalab/core-components-lottie@1.0.0-alfasans-1960cb50f1bb912c4c88a4e9041989958f542451
@alfalab/core-components@50.6.0-alfasans-1960cb50f1bb912c4c88a4e9041989958f542451

SiebenSieben

Отсутствуют unit-тесты. В библиотеке это обязательное требование для каждого компонента — нужен Component.test.tsx. Без тестов сложно гарантировать корректность поведения при будущих изменениях.

SiebenSieben · 2026-03-13T08:00:19Z

+export const lottie: Story = {
+    name: 'Lottie',
+    render: () => {
+        return <Lottie animation={{ path: 'http://localhost:9009/twitter-heart.json' }} />;


Хардкод localhost — в задеплоенном Storybook это сломается. Нужно использовать относительный путь, аналогично тому как сделано в description.mdx (./twitter-heart.json).

SiebenSieben · 2026-03-13T08:00:19Z

+                    direction={direction}
+                    speed={1}
+                    iterations={0}
+                    direction={direction}


Дублирующийся проп direction={direction}. JSX не выдаст ошибку компиляции в MDX, но второй проп перезаписывает первый — нужно убрать одно из вхождений.

SiebenSieben · 2026-03-13T08:00:19Z

+            [events, reset],
+        );
+        useImperativeHandle(playCountRef, () => animation?.playCount ?? 0, [animation]);
+


useImperativeHandle предназначен для кастомизации хендла, прокидываемого наружу через forwardRef. Использование его на внутреннем playCountRef нестандартно и вводит в заблуждение. Достаточно обычного эффекта:

useEffect(() => { playCountRef.current = animation?.playCount ?? 0; }, [animation]);

SiebenSieben · 2026-03-13T08:00:20Z

        'max-params': 'off',
+        'react-hooks/exhaustive-deps':
+            lottiePkg && isSamePath(process.cwd(), lottiePkg.dir)
+                ? ['warn', { additionalHooks: ['useLayoutEffect_SAFE_FOR_SSR'].join('|') }]


Два вопроса по этому изменению:

useLayoutEffect_SAFE_FOR_SSR из @alfalab/hooks используется во всём репозитории, не только в lottie. Если хук нужно добавить в additionalHooks — логичнее сделать это глобально для всех пакетов, а не только при isSamePath(..., lottiePkg.dir).

["useLayoutEffect_SAFE_FOR_SSR"].join("|") возвращает просто "useLayoutEffect_SAFE_FOR_SSR" — .join("|") на массиве из одного элемента избыточен.

SiebenSieben · 2026-03-13T08:00:20Z

+                animationItem.destroy();
+                // eslint-disable-next-line no-underscore-dangle
+                animationItem._cbs = [];
+                setAnimation(null);


Прямая запись в приватное поле _cbs обходит публичный API lottie-web. При обновлении библиотеки это поле может исчезнуть или изменить структуру, и баг будет трудно отловить. Если это необходимо для предотвращения утечек памяти — стоит добавить подробный комментарий, почему это нельзя сделать через animationItem.destroy() или другой публичный способ.

SiebenSieben · 2026-03-13T08:00:20Z

+        "tslib": "^2.4.0"
+    },
+    "peerDependencies": {
+        "react": "^16.9.0 || ^17.0.1 || ^18.0.0",


Все остальные пакеты в репозитории уже добавили поддержку React 19. Нужно привести в соответствие:

"react": "^16.9.0 || ^17.0.1 || ^18.0.0 || ^19.0.0", "react-dom": "^16.9.0 || ^17.0.1 || ^18.0.0 || ^19.0.0"

SiebenSieben · 2026-03-13T08:00:20Z

+            </div>
+        );
+    },
+);


Не хватает displayName — это стандарт библиотеки (см. Button, Checkbox и др.):

Lottie.displayName = "Lottie";

SiebenSieben · 2026-03-13T08:00:20Z

+     * Дополнительный класс
+     */
+    className?: string;
+}


В библиотеке принято поддерживать dataTestId во всех компонентах для использования в автотестах. Нужно добавить проп и прокинуть через data-test-id на корневой элемент.

hextion force-pushed the feat/lottie branch 4 times, most recently from 739f76d to 9dcb40e Compare February 6, 2026 07:17

hextion force-pushed the feat/lottie branch 3 times, most recently from 1ad4b85 to 87fc4f0 Compare February 13, 2026 08:32

hextion force-pushed the feat/lottie branch 2 times, most recently from 53bfe40 to 2a0ca51 Compare March 2, 2026 07:04

hextion marked this pull request as ready for review March 2, 2026 09:10

hextion requested review from SiebenSieben, dHIM24 and fulcanellee as code owners March 2, 2026 09:10

fulcanellee approved these changes Mar 2, 2026

View reviewed changes

hextion force-pushed the feat/lottie branch from 1960cb5 to 4238db0 Compare March 2, 2026 14:14

dHIM24 approved these changes Mar 2, 2026

View reviewed changes

SiebenSieben requested a review from Oladii March 13, 2026 07:28

This comment was marked as duplicate.

Sign in to view

SiebenSieben reviewed Mar 13, 2026

View reviewed changes

hextion force-pushed the feat/lottie branch 3 times, most recently from b31db82 to 8a6e27c Compare March 22, 2026 13:09

hextion added 9 commits April 23, 2026 15:15

feat(lottie): initial commit

bb80f78

refactor(lottie): better

b0dc255

refactor(lottie): better

010fc7d

refactor(lottie): sync params

665b09e

refactor(lottie): better

12122df

chore: changeset

ca92416

chore: lottie in root package

73c230b

chore: missed tslib

39eb654

fix: review

063cd8a

hextion force-pushed the feat/lottie branch from 8a6e27c to 063cd8a Compare April 23, 2026 12:17

Conversation

hextion commented Feb 2, 2026

Uh oh!

changeset-bot Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size report

Uh oh!

coveralls commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 24834735888

Coverage remained the same at 81.985%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

github-actions Bot commented Feb 2, 2026

Demo build

Uh oh!

github-actions Bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo build (default)

Uh oh!

github-actions Bot commented Feb 6, 2026

Demo build (alfasans)

Uh oh!

github-actions Bot commented Mar 2, 2026

Snapshot release (default)

Uh oh!

github-actions Bot commented Mar 2, 2026

Snapshot release (alfasans)

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

SiebenSieben left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

changeset-bot Bot commented Feb 2, 2026 •

edited

Loading

github-actions Bot commented Feb 2, 2026 •

edited

Loading

coveralls commented Feb 2, 2026 •

edited

Loading

github-actions Bot commented Feb 6, 2026 •

edited

Loading