Skip to content

fix(list): исправить нечитаемый текст в темной теме [DS-16489]#2180

Open
dHIM24 wants to merge 1 commit into
masterfrom
DS-16489
Open

fix(list): исправить нечитаемый текст в темной теме [DS-16489]#2180
dHIM24 wants to merge 1 commit into
masterfrom
DS-16489

Conversation

@dHIM24
Copy link
Copy Markdown
Contributor

@dHIM24 dHIM24 commented Apr 17, 2026

List
  • Убраны глобальные :root-переменные и форсирование --color-light-text-primary, из-за которых в dark theme текст мог становиться нечитаемым.

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • Добавленные пропсы добавлены в демки и описаны в документации
  • К реквесту добавлен changeset

Если есть визуальные изменения

  • Прикреплено изображение было/стало

#1960

Было:

Снимок экрана 2026-04-28 в 01 16 05

Стало:

Снимок экрана 2026-04-28 в 01 04 07

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2026

🦋 Changeset detected

Latest commit: 5d55ae8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@alfalab/core-components-list Patch
@alfalab/core-components Patch
@alfalab/core-components-markdown Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 17, 2026

Coverage Report for CI Build 24655066235

Coverage remained the same at 82.003%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11604
Covered Lines: 9596
Line Coverage: 82.7%
Relevant Branches: 2176
Covered Branches: 1704
Branch Coverage: 78.31%
Branches in Coverage %: Yes
Coverage Strength: 230.47 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2180

@github-actions
Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2180-alfasans

@dHIM24 dHIM24 marked this pull request as ready for review April 27, 2026 22:48

:root {
--list-marker-color: var(--color-light-text-primary);
--list-item-margin: var(--gap-12);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

почему переменная ушла?


&.defaultColor {
color: var(--list-marker-color);
color: currentColor;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

насколько корректный фикс? откуда цвет в итоге возьмется?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants