Skip to content

fix(bottom-sheet): исправлен скачок magnetic-areas [DS-16410/version-49]#2199

Draft
dHIM24 wants to merge 1 commit into
version/49from
DS-16410-49
Draft

fix(bottom-sheet): исправлен скачок magnetic-areas [DS-16410/version-49]#2199
dHIM24 wants to merge 1 commit into
version/49from
DS-16410-49

Conversation

@dHIM24
Copy link
Copy Markdown
Contributor

@dHIM24 dHIM24 commented May 4, 2026

BottomSheet
  • Исправлено нестабильное поведение BottomSheet при динамической смене magneticAreas.
  • Если после обновления magneticAreas активный индекс выходит за границы массива (например, когда массив стал короче), компонент теперь переводит шторку в ближайшую доступную магнитную область вместо сброса в offset 0. Это устраняет рывки и визуальные скачки, сохраняя ближайшую предыдущую высоту.

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • Добавленные пропсы добавлены в демки и описаны в документации
  • К реквесту добавлен changeset

Если есть визуальные изменения

  • Прикреплено изображение было/стало

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

🦋 Changeset detected

Latest commit: 56ce51f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-table Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dHIM24 dHIM24 changed the title Ds 16410 49 fix(bottom-sheet): исправлен скачок magnetic-areas [DS-16410/version-49] May 4, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25305933843

Coverage increased (+0.04%) to 84.67%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (15 of 16 lines covered, 93.75%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
packages/bottom-sheet/src/component.tsx 16 15 93.75%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11438
Covered Lines: 9751
Line Coverage: 85.25%
Relevant Branches: 2111
Covered Branches: 1721
Branch Coverage: 81.53%
Branches in Coverage %: Yes
Coverage Strength: 234.4 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Demo build (default)

https://core-ds.github.io/core-components/2199

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Snapshot release

Successfully released the following packages:

  1. @alfalab/core-components-bottom-sheet@7.4.6-56ce51fd67b94938a5f707982f594e4ce32cea61

  2. @alfalab/core-components-custom-picker-button@3.2.2-56ce51fd67b94938a5f707982f594e4ce32cea61

  3. @alfalab/core-components-gallery@6.0.16-56ce51fd67b94938a5f707982f594e4ce32cea61

  4. @alfalab/core-components-input-autocomplete@13.1.6-56ce51fd67b94938a5f707982f594e4ce32cea61

  5. @alfalab/core-components-international-phone-input@3.2.14-56ce51fd67b94938a5f707982f594e4ce32cea61

  6. @alfalab/core-components-intl-phone-input@10.0.17-56ce51fd67b94938a5f707982f594e4ce32cea61

  7. @alfalab/core-components-picker-button@12.1.6-56ce51fd67b94938a5f707982f594e4ce32cea61

  8. @alfalab/core-components@49.17.1-56ce51fd67b94938a5f707982f594e4ce32cea61

  9. @alfalab/core-components-select@18.3.2-56ce51fd67b94938a5f707982f594e4ce32cea61

  10. @alfalab/core-components-select-with-tags@9.1.2-56ce51fd67b94938a5f707982f594e4ce32cea61

  11. @alfalab/core-components-table@3.0.17-56ce51fd67b94938a5f707982f594e4ce32cea61

  12. @alfalab/core-components-tabs@9.2.14-56ce51fd67b94938a5f707982f594e4ce32cea61

  13. @alfalab/core-components-tooltip@8.0.15-56ce51fd67b94938a5f707982f594e4ce32cea61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants