Skip to content

feat/DS-15531_clear#2203

Open
fulcanellee wants to merge 29 commits into
masterfrom
feat/DS-15531_clear
Open

feat/DS-15531_clear#2203
fulcanellee wants to merge 29 commits into
masterfrom
feat/DS-15531_clear

Conversation

@fulcanellee
Copy link
Copy Markdown
Contributor

DS-15531

Input

Раобота пропа clear разделена на 2 механики:

  • true или default — стандартная механика, отображается только при взаимодействии
  • search — поисковая механика, отображается всегда

@fulcanellee fulcanellee marked this pull request as draft May 6, 2026 07:39
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

🦋 Changeset detected

Latest commit: 5d444de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@alfalab/core-components Minor
@alfalab/core-components-input Minor
@alfalab/core-components-amount-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2026

Coverage Report for CI Build 25854781040

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.07%) to 82.234%

Details

  • Coverage decreased (-0.07%) from the base build.
  • Patch coverage: 4 uncovered changes across 1 file (9 of 13 lines covered, 69.23%).
  • 3 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
packages/input/src/components/base-input/Component.tsx 13 9 69.23%

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
packages/universal-modal/src/desktop/utils/get-margin-styles.ts 2 75.0%
packages/base-modal/src/Component.tsx 1 91.84%

Coverage Stats

Coverage Status
Relevant Lines: 11621
Covered Lines: 9629
Line Coverage: 82.86%
Relevant Branches: 2209
Covered Branches: 1744
Branch Coverage: 78.95%
Branches in Coverage %: Yes
Coverage Strength: 235.5 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Demo build (default)

https://core-ds.github.io/core-components/2203

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Demo build (alfasans)

https://core-ds.github.io/core-components/2203-alfasans

@fulcanellee fulcanellee marked this pull request as ready for review May 6, 2026 08:48
@fulcanellee fulcanellee requested a review from Oladii May 6, 2026 08:48
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не уверен что в название пропа стоит зашивать Search
мб безопасней будет просто описать clear: always, onHover или типо того?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

статус прыгает, остальное ок)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправлено

@fulcanellee fulcanellee requested a review from Oladii May 14, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants