add total build time to -v output, harden dispatchNamedObject#497
Merged
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
`chad build -v foo.ts` now appends " in Xms" to the "Compiled: ..." line. Useful when something feels slow and you want to know without reaching for the shell's `time`. No behavior change at default verbosity. The one-line `return null;` added to `MethodCallGenerator.dispatchNamedObject` after the switch-with-default is a workaround for a native-compiler false positive in checkMissingReturns: any edit to compileNative's body shifts AST layout enough to trip it on dispatchNamedObject. The extra trailing return makes the function immune. Node compiler accepts the original code fine; this only affects the self-hosted path.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chad build -v foo.tsnow appends ` in Xms` to the existing `Compiled: ...` line. Cheap way to see total build time without reaching for the shell's `time`. No change at default verbosity.Why the two changes ship together
They're not logically coupled, but they're operationally coupled: landing the timing change alone reliably trips the `dispatchNamedObject` false positive. Verified by bisection — even a 2-line timing edit is enough.
Test plan
Root cause note
The underlying `checkMissingReturns` / `mrAllReturn` codegen bug is documented in memory (`native-missing-returns-false-positive.md`) for future sessions. This PR is a workaround for that specific function, not a fix for the root cause. The real fix lives in `src/semantic/safety-checks.ts` `mrAllReturn` and is a separate effort.