dbeaver/pro#9090 refactor: use new getters for sql execution plan#4333
Open
SychevAndrey wants to merge 2 commits into
Open
dbeaver/pro#9090 refactor: use new getters for sql execution plan#4333SychevAndrey wants to merge 2 commits into
SychevAndrey wants to merge 2 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SQL execution plan flow to expose newly available execution-plan metadata to the UI layer and to request additional execution-plan node metrics from the GraphQL API.
Changes:
- Passes
hasCost,hasRows,hasDuration, anddurationMeasurefrom the execution plan result into execution plan tab views. - Extends
ISqlExecutionPlanViewPropswith the new execution-plan capability flags. - Expands
getSqlExecutionPlanResultGraphQL query to request node metrics (cost,rowCount,duration,percent).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| webapp/packages/plugin-sql-editor/src/SqlResultTabs/ExecutionPlan/SqlExecutionPlanPanel.tsx | Forwards new execution plan metadata into the TabsState view props. |
| webapp/packages/plugin-sql-editor/src/SqlResultTabs/ExecutionPlan/ISqlExecutionPlanViewProps.ts | Extends the execution plan view contract with new required metadata fields. |
| webapp/packages/core-sdk/src/queries/grid/getSqlExecutionPlanResult.gql | Requests additional execution plan node metrics from the backend. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| hasCost={data.executionPlan.hasCost} | ||
| hasRows={data.executionPlan.hasRows} | ||
| hasDuration={data.executionPlan.hasDuration} | ||
| durationMeasure={data.executionPlan.durationMeasure} |
sergeyteleshev
approved these changes
May 12, 2026
…owcount-duration-percent-on-fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.