[3.x] Allow a Shard Manager to handle multiple groups of pods (roles)#157
Merged
Conversation
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
reviewed
Apr 4, 2025
civilizeddev
approved these changes
Apr 4, 2025
nox213
approved these changes
Apr 4, 2025
Contributor
nox213
left a comment
nox213
left a comment
There was a problem hiding this comment.
I mainly reviewed ShardManager.scala
# Conflicts: # build.sbt # entities/src/main/scala/com/devsisters/shardcake/ShardManagerClient.scala # manager/src/main/scala/com/devsisters/shardcake/ShardManager.scala
ghostdogpr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
Pods can now be tagged with a Role, and the Shard Manager manages each role as an independent shard pool (its own shards, rebalancing, and assignments). Pods with different roles never share shards, which lets you dedicate certain pods to certain entity types or scale parts of the system independently.