Skip to content

Cliques coverage#923

Open
mtorpey wants to merge 3 commits intodigraphs:mainfrom
mtorpey:cliques-coverage
Open

Cliques coverage#923
mtorpey wants to merge 3 commits intodigraphs:mainfrom
mtorpey:cliques-coverage

Conversation

@mtorpey
Copy link
Copy Markdown
Collaborator

@mtorpey mtorpey commented Apr 25, 2026

This brings cliques.gi to 100% coverage. And it was a nice exercise in understanding the Bron–Kerbosch algorithm and @wilfwilson's excellent 10-year-old implementation of it.

The commits are again logical and distinct, so might want to avoid squashing when merging.

@mtorpey mtorpey added minor A label for PRs or issues that are minor in some sense. tests A label for issues/PRs relating to adding or updating tests or the testing system labels Apr 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (313228b) to head (9b3e01a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   97.38%   97.40%   +0.01%     
==========================================
  Files          50       50              
  Lines       21193    21193              
  Branches      639      639              
==========================================
+ Hits        20639    20643       +4     
+ Misses        489      485       -4     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mo-wilfwilson
Copy link
Copy Markdown

So kind, @mtorpey

Copy link
Copy Markdown

@mo-wilfwilson mo-wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a beautiful addition, to me

Copy link
Copy Markdown
Collaborator

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, and now I've approved it from my personal account too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor A label for PRs or issues that are minor in some sense. tests A label for issues/PRs relating to adding or updating tests or the testing system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants