Allow IMallocSpy callbacks during LPSTR/LPWSTR array cleanup#126571
Draft
Allow IMallocSpy callbacks during LPSTR/LPWSTR array cleanup#126571
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/68c1bb22-8f29-41a2-86b8-b039f3aa63bc Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Interop/COM/ExtensionPoints.cmd test failure
Allow IMallocSpy callbacks during LPSTR/LPWSTR array cleanup
Apr 6, 2026
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
jkotas
reviewed
Apr 6, 2026
| CONTRACTL | ||
| { | ||
| NOTHROW; | ||
| THROWS; // CoTaskMemFree can invoke a managed IMallocSpy implementation. |
Member
There was a problem hiding this comment.
This method is not expected to throw. This contract is correct.
I think this should be fixed by fixing the contracts on the new COM interop implementation. The exceptions are not expected to leak from the COM interop HRESULT-returning methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interop/COM/ExtensionPointswas failing because the marshaling cleanup path freedCoTaskMembuffers under aNOTHROWcontract. When a managedIMallocSpyis registered,CoTaskMemFreecan re-enter managed code and violate that contract.Cleanup contract fix
OleVariant::ClearLPSTRArrayandOleVariant::ClearLPWSTRArrayto useTHROWS.CoTaskMemFreewhen COM allocation hooks dispatch into managedIMallocSpyimplementations.Why this addresses the failure
string[]through an unmanaged function pointer, which allocates and later freesLPSTR*buffers.Relevant change