Show offers in dstack apply for elastic container fleets#3754
Open
peterschmidt85 wants to merge 1 commit intomasterfrom
Open
Show offers in dstack apply for elastic container fleets#3754peterschmidt85 wants to merge 1 commit intomasterfrom
peterschmidt85 wants to merge 1 commit intomasterfrom
Conversation
Use run-capable offer lookup for cloud fleets with nodes.min=0 and nodes.target=0, while keeping create-instance filtering for non-elastic fleets.\n\nAdds router tests for elastic container backend offers and preserves no-offers behavior for non-elastic container fleets.
peterschmidt85
changed the title
r4victor
reviewed
Apr 8, 2026
Comment on lines
+446
to
+463
| if _is_elastic_cloud_fleet_spec(effective_spec): | ||
| offers_with_backends = await offers_services.get_offers_by_requirements( | ||
| project=project, | ||
| profile=effective_spec.merged_profile, | ||
| requirements=requirements, | ||
| multinode=( | ||
| effective_spec.configuration.placement == InstanceGroupPlacement.CLUSTER | ||
| ), | ||
| blocks=effective_spec.configuration.blocks, | ||
| ) | ||
| else: | ||
| offers_with_backends = await get_create_instance_offers( | ||
| project=project, | ||
| profile=effective_spec.merged_profile, | ||
| requirements=requirements, | ||
| fleet_spec=effective_spec, | ||
| blocks=effective_spec.configuration.blocks, | ||
| ) |
Collaborator
There was a problem hiding this comment.
Having two branches with get_offers_by_requirements and get_create_instance_offers seems too verbose here. I think it can be replaced with a get_create_instance_offers param that would enable/disable BACKENDS_WITH_CREATE_INSTANCE_SUPPORT filtering.
r4victor
reviewed
Apr 8, 2026
| return plan | ||
|
|
||
|
|
||
| def _is_elastic_cloud_fleet_spec(fleet_spec: FleetSpec) -> bool: |
Collaborator
There was a problem hiding this comment.
This function name is a misnomer since it does not really check that the fleet is elastic (nodes is a range) but that nodes.target == 0. And since target cannot be less than min, that's all we need to check for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Expected
dstack applyshould show matching offers for elastic container-based fleets, since runs are provisioned on demand from those offers.This is important not only for offer visibility/convenience, but also for consistency: VM-based elastic fleets already show offers during
apply, and container-based elastic fleets should behave the same way.Actual
No offers were shown for elastic container-based fleets during
apply, even when offers existed.Solution
In fleet plan generation:
nodes.min == 0andnodes.target == 0), use run-capable offer lookup (get_offers_by_requirements).get_create_instance_offers).This keeps non-elastic behavior unchanged and fixes offer preview UX for elastic container backends.
AI Assistance
This PR was prepared with AI assistance (Codex).