Normalize cargo registry paths for any registry source#331
Open
devjgm wants to merge 1 commit into
Open
Conversation
Extract a `normalize_cargo_registry` function that matches any cargo
registry source path of the form:
.../registry/src/{name}-{16-hex-chars}/...
replacing the prefix up to and including the hash with `$CARGO`.
Previously the `CargoRegistry` normalization only recognized
`github.com-` and `index.crates.io-` as registry source directories,
causing custom registries (CDN mirrors, private registries, etc.) to
appear un-normalized in snapshot comparisons.
Using `rfind('-')` on the directory name segment correctly handles
registry hostnames that themselves contain hyphens.
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for caching proxies and other custom registries used as crates-io replacements. Previously, only
github.com-andindex.crates.io-source directories were normalized to$CARGO; any other registry host caused raw paths to appear in snapshot comparisons, making it difficult to maintain "snapshot" tests usingtrybuildthat work on a developers local machine (using crates.io) and in a docker container in CI that's pointed at a caching proxy of crates.io.Extracts a
normalize_cargo_registryhelper that matches any registry source directory of the form/registry/src/{name}-{16-hex-chars}.