Draft
Conversation
Decrypts wallet2 `.keys` files in pure Rust (cn_slow_hash KDF + ChaCha20 + epee). For `SeedChoice::FromWalletPath`, derive the seed and primary address from the `.keys` file up front so monero-sys open and Bitcoin wallet init can run concurrently via `tokio::try_join!`.
binarybaron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
monero-wallet2-adaptercrate that decrypts wallet2.keysfiles in pure Rust (cn_slow_hash KDF + ChaCha20 + epee). The CLI context builder uses it on theFromWalletPathpath to derive the app seed and primary address up front, which lets the Monero wallet open and Bitcoin wallet init run in parallel viatokio::try_join!. Other seed choices fall back to the existing sequential flow. Includes end-to-end fixtures generated frommonero-wallet-rpcand an address-derivation unit test cross-checked against those fixtures.