Skip to content

[BHP1-1565] Refactor VMS Sidebar Navigation#226

Merged
Kcheung42 merged 10 commits into
mainfrom
kc-BHP1-1565-refactor-vms-sidebar
May 19, 2026
Merged

[BHP1-1565] Refactor VMS Sidebar Navigation#226
Kcheung42 merged 10 commits into
mainfrom
kc-BHP1-1565-refactor-vms-sidebar

Conversation

@Kcheung42
Copy link
Copy Markdown
Collaborator

@Kcheung42 Kcheung42 commented May 4, 2026


Purpose

  • Improve VMS sidebar navigation

Related Issues

Closes BHP1-1565

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Open VMS and checkout the new sidebar navigation

Screenshots

image

@rjsheperd
Copy link
Copy Markdown
Contributor

This is neat!

I would recommend making the text a bit smaller so the sidebar doesn't take up as much room. In addition, having some way to identify modules/submodules/groups/variables would be nice.

Take a look at the linter errors here: https://github.com/firelab/behave-app/runs/74285769982

@Kcheung42
Copy link
Copy Markdown
Collaborator Author

updated

@rjsheperd
Copy link
Copy Markdown
Contributor

@Kcheung42 still some linting errors: https://github.com/firelab/behave-app/runs/76091714142

@Kcheung42
Copy link
Copy Markdown
Collaborator Author

I had to update a few things about the clj-kondo workflow.

  1. Needed to filter out files that have been deleted and not flag it for warning
  2. clj-kondo was flagging undeclared vars coming from behave-cms.store, but I didn't see this in my local machine. I added a step to build kondo's analysis cache built for the full codebase.

@rjsheperd
Copy link
Copy Markdown
Contributor

Looks good! 👍

@Kcheung42 Kcheung42 merged commit 00ae026 into main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants