Skip to content

refactor: extract shared definitions from extension.ts#539

Merged
magnus-madsen merged 1 commit into
masterfrom
refactor/extract-shared-from-extension
Mar 28, 2026
Merged

refactor: extract shared definitions from extension.ts#539
magnus-madsen merged 1 commit into
masterfrom
refactor/extract-shared-from-extension

Conversation

@magnus-madsen
Copy link
Copy Markdown
Member

@magnus-madsen magnus-madsen commented Mar 28, 2026

Summary

  • Extract workspace query functions (isProjectMode, glob patterns) to util/workspace.ts
  • Extract LaunchOptions interface and defaultLaunchOptions to util/launchOptions.ts
  • No module imports from extension.ts anymore — the entry point is now a pure orchestrator with zero dependents, eliminating all circular dependency risk

Test plan

  • tsc --noEmit passes (client)
  • npm run build passes (esbuild bundle)
  • prettier --check passes
  • Grep confirms zero imports from extension.ts
  • Existing integration tests pass (npm test)

🤖 Generated with Claude Code

Move workspace query functions (isProjectMode, glob patterns) to
util/workspace.ts and LaunchOptions type to util/launchOptions.ts.

No module imports from extension.ts anymore — the entry point is now
a pure orchestrator with zero dependents.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@magnus-madsen magnus-madsen merged commit ddd6c8c into master Mar 28, 2026
13 of 14 checks passed
@magnus-madsen magnus-madsen deleted the refactor/extract-shared-from-extension branch March 28, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant