Add dart_skills_lint to devtools and configure it to run in the cli and in tests#9770
Open
reidbaker wants to merge 12 commits intoflutter:masterfrom
Open
Add dart_skills_lint to devtools and configure it to run in the cli and in tests#9770reidbaker wants to merge 12 commits intoflutter:masterfrom
reidbaker wants to merge 12 commits intoflutter:masterfrom
Conversation
reidbaker
commented
Apr 14, 2026
Author
|
I think this is ready for a second pass. |
| build_runner: ^2.5.4 | ||
| flutter_lints: ^5.0.0 | ||
| # Update to published version tracked in https://github.com/flutter/devtools/issues/9771 | ||
| dart_skills_lint: |
Member
There was a problem hiding this comment.
why do we need the dep here and in tool/pubspec.yaml?
Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>
Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>
| dev_dependencies: | ||
| build_runner: ^2.5.4 | ||
| flutter_lints: ^5.0.0 | ||
|
|
Author
There was a problem hiding this comment.
FWIW the reason dart_skills_lint was added here was for ease of cli usage. The comment to share yaml configs is what lead me to move it all to the tools package.
reidbaker
commented
Apr 16, 2026
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "skills": { | |||
| "adding-release-notes": [ | |||
Author
There was a problem hiding this comment.
This is still required because the example for image does not resolve.
| dev_dependencies: | ||
| build_runner: ^2.5.4 | ||
| flutter_lints: ^5.0.0 | ||
|
|
| dev_dependencies: | ||
| build_runner: ^2.5.4 | ||
| flutter_lints: ^5.0.0 | ||
|
|
Author
There was a problem hiding this comment.
FWIW the reason dart_skills_lint was added here was for ease of cli usage. The comment to share yaml configs is what lead me to move it all to the tools package.
8 tasks
kenzieschmoll
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed. But I asked kenzie first.Tests checklist
AI-tooling checklist
Feature-change checklist
release-notes-not-requiredlabel or left a comment requesting the label be added.packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.This does not need release notes because it adds tests and instructions for contributors only.