Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes legacy Google Analytics (GA) logic across several packages and refactors the web analytics implementation to use a Dart-based event system, replacing previous JS interop calls. Key changes include the removal of legacy server endpoints, the deletion of gtags.dart and devtools_analytics.js, and the introduction of type-safe enums for analytics parameters. Review feedback highlighted critical logical issues in _analytics_web.dart, specifically regarding the misuse of immutable string methods, a potential out-of-bounds error during list iteration, and the use of unnormalized platform strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the legacy analytics so that we no longer send analytics to two separate GA4 ids. Changes covered by existing tests.
Fixes #9765.
Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed.Tests checklist
AI-tooling checklist
Feature-change checklist
release-notes-not-requiredlabel or left a comment requesting the label be added.packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.If you need help, consider asking for help on Discord.