Skip to content

fix(queue): [Queue Instrumentation 42] Review Changes#5368

Draft
adinauer wants to merge 4 commits intofeat/queue-instrumentation-spring-boot-2from
fix/queue-instrumentation-review-changes
Draft

fix(queue): [Queue Instrumentation 42] Review Changes#5368
adinauer wants to merge 4 commits intofeat/queue-instrumentation-spring-boot-2from
fix/queue-instrumentation-review-changes

Conversation

@adinauer
Copy link
Copy Markdown
Member

@adinauer adinauer commented May 5, 2026

PR Stack (Queue Instrumentation)


📜 Description

Applies follow-up review changes across the queue instrumentation stack.

This updates Kafka consumer transaction names to use the record topic, applies the same behavior to Spring Kafka record interceptors, keeps tests aligned, and trims explanatory comments/docs that were too implementation-specific.

💡 Motivation and Context

These are follow-up fixes for the Queue Instrumentation stack before it is merged. Keeping them as the next stacked PR makes the review adjustments easy to inspect separately from the larger Spring Boot porting PRs.

💚 How did you test it?

  • ./gradlew spotlessApply apiDump
  • ./gradlew :sentry-kafka:test --tests '*Kafka*' :sentry-spring:test --tests '*Kafka*' :sentry-spring-jakarta:test --tests '*Kafka*' :sentry-spring-7:test --tests '*Kafka*' :sentry-opentelemetry:sentry-opentelemetry-core:test --tests '*SpanDescriptionExtractor*' --tests '*SentrySpanExporter*'

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

None.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

This was referenced May 5, 2026
@sentry
Copy link
Copy Markdown

sentry Bot commented May 5, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.37.1 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 307.76 ms 360.39 ms 52.63 ms
Size 0 B 0 B 0 B

Baseline results on branch: feat/queue-instrumentation-spring-boot-2

Startup times

Revision Plain With Sentry Diff
6432a3a 345.23 ms 421.67 ms 76.44 ms
ccba042 319.40 ms 359.81 ms 40.41 ms
c1fb851 446.80 ms 553.50 ms 106.70 ms

App size

Revision Plain With Sentry Diff
6432a3a 0 B 0 B 0 B
ccba042 0 B 0 B 0 B
c1fb851 0 B 0 B 0 B

Previous results on branch: fix/queue-instrumentation-review-changes

Startup times

Revision Plain With Sentry Diff
e5f8da7 311.30 ms 354.02 ms 42.72 ms

App size

Revision Plain With Sentry Diff
e5f8da7 0 B 0 B 0 B

Copy link
Copy Markdown
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants