Initial implementation of rule 4-1-1, must be standard C++17

[MichaelRFairhurst]

Description

please enter the description of your change here

Change request type

• Release or process automation (GitHub workflows, internal scripts)
• Internal documentation
• External documentation
• Query files (.ql, .qll, .qls or unit tests)
• External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

• No rules added
• Queries have been added for the following rules:
  • RULE-4-1-1
• Queries have been modified for the following rules:
  • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

• The structure or layout of the release artifacts.
• The evaluation performance (memory, execution time) of an existing query.
• The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

• Yes
• No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

• Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

• Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

Reviewer

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

[Copilot]

Pull request overview

Adds the initial CodeQL implementation for MISRA C++:2023 RULE-4-1-1 (“must be standard C++17”) by modeling several common compiler-language extensions and wiring the rule into the toolchain package and test suite.

Changes:

• Introduces a new rule query (CompilerLanguageExtensionsUsed) and a shared library model of C++ compiler extensions.
• Adds a dedicated unit test directory with a .qlref and .expected results for RULE-4-1-1.
• Wires the rule into Toolchain2 packaging/metadata and updates standard-library test stubs needed by the test.

Show a summary per file

File	Description
rule_packages/cpp/Toolchain2.json	Adds MISRA-C++-2023 RULE-4-1-1 metadata and query descriptor in Toolchain2 package.
cpp/misra/src/rules/RULE-4-1-1/CompilerLanguageExtensionsUsed.ql	New rule query selecting detected compiler extensions and reporting messages.
cpp/common/src/codingstandards/cpp/Extensions.qll	Adds the core modeling of C++ compiler extensions and associated alert messages.
cpp/misra/test/rules/RULE-4-1-1/test.cpp	New test cases covering attributes, builtins, statement expressions, pragmas, etc.
cpp/misra/test/rules/RULE-4-1-1/CompilerLanguageExtensionsUsed.qlref	Test reference to the production query.
cpp/misra/test/rules/RULE-4-1-1/CompilerLanguageExtensionsUsed.expected	Expected results for the test query execution.
cpp/common/test/includes/standard-library/type_traits.h	Extends the type-traits stub to support test compilation.
cpp/common/src/codingstandards/cpp/exclusions/cpp/Toolchain2.qll	Autogenerated Toolchain2 query metadata wrapper for exclusions.
cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll	Registers Toolchain2 metadata with the exclusions framework.

Copilot's findings

Comments suppressed due to low confidence (2)

cpp/common/src/codingstandards/cpp/Extensions.qll:126

• Some message strings exceed the repo's 100-character line limit for CodeQL source/test files (for example, this line). Please wrap these strings across multiple lines to keep each source line ≤ 100 characters.

  override string getMessage() {
    result =
      "Extended floating-point types are a compiler extension and are not portable to other compilers."
  }

cpp/common/src/codingstandards/cpp/Extensions.qll:203

• CPPPreprocessorDirectiveExtension is a new public class (not marked private) but it does not have a QLDoc comment. Add QLDoc (or mark it private / document it as INTERNAL) to satisfy the project's documentation requirements for public declarations.

class CPPPreprocessorDirectiveExtension extends CPPCompilerExtension, PreprocessorDirective {
  string kind;

  CPPPreprocessorDirectiveExtension() {
    this instanceof PreprocessorPragma and kind = "#pragma " + getHead()
    or

• Files reviewed: 9/9 changed files
• Comments generated: 8

[mbaluda]

LGTM!
Suggested an improvement to the error message