Skip to content

fix: use govulncheck -scan=module for library CI#32

Merged
ankurs merged 1 commit intomainfrom
fix/govulncheck-scan-module
Apr 23, 2026
Merged

fix: use govulncheck -scan=module for library CI#32
ankurs merged 1 commit intomainfrom
fix/govulncheck-scan-module

Conversation

@ankurs
Copy link
Copy Markdown
Member

@ankurs ankurs commented Apr 23, 2026

Summary

  • Use govulncheck -scan=module instead of govulncheck ./... in CI

Libraries should scan dependencies (go.mod), not stdlib — the stdlib version is the consumer's choice, not the library's. -scan=module checks only dependency vulnerabilities, avoiding false failures when the CI Go toolchain has unfixed stdlib CVEs.

Test plan

  • make lint passes locally

Libraries should scan dependencies, not stdlib — the stdlib version
is the consumer's choice. -scan=module checks only go.mod deps.
Copilot AI review requested due to automatic review settings April 23, 2026 02:49
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@ankurs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 37 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 37 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b92b25be-38a0-4bfa-bc5d-a9d7a60bee8c

📥 Commits

Reviewing files that changed from the base of the PR and between 06ce8d6 and 9c8b73d.

📒 Files selected for processing (1)
  • Makefile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/govulncheck-scan-module

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI lint step to run govulncheck in module-scanning mode so the library’s vulnerability checks focus on dependency versions (go.mod) rather than the Go toolchain’s stdlib.

Changes:

  • Switch govulncheck invocation in make lint from ./... scanning to -scan=module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ankurs ankurs merged commit 21b1808 into main Apr 23, 2026
11 checks passed
@ankurs ankurs deleted the fix/govulncheck-scan-module branch April 23, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants