Skip to content

fix: publishing test failures#232

Open
ncooke3 wants to merge 3 commits intomainfrom
nc/test-fix
Open

fix: publishing test failures#232
ncooke3 wants to merge 3 commits intomainfrom
nc/test-fix

Conversation

@ncooke3
Copy link
Copy Markdown
Member

@ncooke3 ncooke3 commented Apr 16, 2026 •
edited
Loading

https://github.com/google/GoogleUtilities/pull/232/changes?w=1

Attempt to address test failures that failed pod trunk push:

    - NOTE  | [OSX] xcodebuild:  GoogleUtilities/GoogleUtilities/Tests/Unit/Swizzler/GULRuntimeSnapshotTests.m:92: error: -[GULRuntimeSnapshotTests testCapture] : (([snapshot1 capture]) does not throw) failed: throwing "NSInvalidArgumentException: *** -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil"
    - NOTE  | [OSX] xcodebuild:  GoogleUtilities/GoogleUtilities/Tests/Unit/Swizzler/GULRuntimeSnapshotTests.m:95: error: -[GULRuntimeSnapshotTests testCapture] : (([snapshot2 capture]) does not throw) failed: throwing "NSInvalidArgumentException: *** -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil"
    - NOTE  | [OSX] xcodebuild:  GoogleUtilities/GoogleUtilities/SwizzlerTestHelpers/GULRuntimeSnapshot.m:81: error: -[GULRuntimeSnapshotTests testClassRemovedDetected] : *** -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil (NSInvalidArgumentException)
    - NOTE  | [OSX] xcodebuild:  GoogleUtilities/GoogleUtilities/SwizzlerTestHelpers/GULRuntimeSnapshot.m:81: error: -[GULRuntimeSnapshotTests testNewClassDetected] : *** -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil (NSInvalidArgumentException)
    - NOTE  | [OSX] xcodebuild:  GoogleUtilities/GoogleUtilities/Tests/Unit/Swizzler/GULRuntimeStateHelperTests.m:36: error: -[GULRuntimeStateHelperTests testCaptureRuntimeState] : ((snapshot1 = [GULRuntimeStateHelper captureRuntimeState]) does not throw) failed: throwing "NSInvalidArgumentException: *** -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil"
    - NOTE  | [OSX] xcodebuild:  GoogleUtilities/GoogleUtilities/SwizzlerTestHelpers/GULRuntimeSnapshot.m:81: error: -[GULRuntimeStateHelperTests testDiffBetweenFirstSnapshotSecondSnapshot] : *** -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil (NSInvalidArgumentException)

Also reproducible by:

pod spec lint GoogleUtilities.podspec --platforms=macos --sources=git@github.com:firebase/SpecsStaging.git,https://cdn.cocoapods.org

Manual Testing

nickcooke@nickcooke-mac2 GoogleUtilities (nc/test-fix) % pod lib lint GoogleUtilities.podspec --platforms=macos    

 -> GoogleUtilities (8.1.1)
    - NOTE  | [GoogleUtilities/Privacy, GoogleUtilities/Environment, GoogleUtilities/Logger, and more...] xcodebuild:  note: Using codesigning identity override: 
    - NOTE  | [GoogleUtilities/Privacy, GoogleUtilities/Environment, GoogleUtilities/Logger, and more...] xcodebuild:  note: Building targets in dependency order
    - NOTE  | [GoogleUtilities/Privacy, GoogleUtilities/Environment, GoogleUtilities/Logger, and more...] xcodebuild:  note: Target dependency graph (4 targets)
    - NOTE  | [OSX] xcodebuild:  note: Target dependency graph (5 targets)
    - NOTE  | xcodebuild:  note: Using stub executor library without Swift entry point. (in target 'AppHost-GoogleUtilities-Unit-Tests' from project 'Pods')
    - NOTE  | [OSX] xcodebuild:  Pods.xcodeproj: OCMock: ld: warning: building for macOS-11.0, but linking with dylib '@rpath/XCTest.framework/Versions/A/XCTest' which was built for newer version 14.0
    - NOTE  | [OSX] xcodebuild:  Pods.xcodeproj: GoogleUtilities-Unit-unit: ld: warning: building for macOS-11.0, but linking with dylib '@rpath/XCTest.framework/Versions/A/XCTest' which was built for newer version 14.0
    - NOTE  | [OSX] xcodebuild:  Pods.xcodeproj: GoogleUtilities-Unit-unit: ld: warning: building for macOS-11.0, but linking with dylib '@rpath/libXCTestSwiftSupport.dylib' which was built for newer version 14.0
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:26.902128-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519078] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:26.902896-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519078] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:26.903552-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519078] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  Test Case '-[GULNetworkTest testEmptyURLNSURLSe2026-04-16 14:54:26.906606-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519250] [[GULNetwork]]  - [GULNetwork][I-NET900002] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:26.906937-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519250] [[GULNetwork]]  - [GULNetwork][I-NET900002] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:26.906960-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519250] [[GULNetwork]]  - [GULNetwork][I-NET900002] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:26.907376-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519078] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:26.907885-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519250] [[GULNetwork]]  - [GULNetwork][I-NET900002] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:27.111975-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519078] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:27.115159-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519078] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:27.115896-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519078] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:27.122324-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519078] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:27.125734-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519252] [[GULNetwork]]  - [GULNetwork][I-NET900002] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:27.125873-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519252] [[GULNetwork]]  - [GULNetwork][I-NET900002] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  37-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519252] [[GULNetwork]]  - [GULNetwork][I-NET900002] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:27.143792-0400 AppHost-GoogleUtilities-Unit-Tests[16272:11519252] [[GULNetwork]]  - [GULNetwork][I-NET900002] <Google/Utilities/Network/WARNING> Failed to create network request. Code, error: 1, Error Domain=com.gul.network.ErrorDomain Code=1 "(null)" UserInfo={Context=Failed to create network request}
    - NOTE  | [OSX] xcodebuild:  Pods.xcodeproj: GoogleUtilities-Unit-unit-swift: ld: warning: building for macOS-11.0, but linking with dylib '@rpath/XCTest.framework/Versions/A/XCTest' which was built for newer version 14.0
    - NOTE  | [OSX] xcodebuild:  Pods.xcodeproj: GoogleUtilities-Unit-unit-swift: ld: warning: building for macOS-11.0, but linking with dylib '@rpath/libXCTestSwiftSupport.dylib' which was built for newer version 14.0
    - NOTE  | [OSX] xcodebuild:  2026-04-16 14:54:49.522 appintentsmetadataprocessor[16487:11520490] warning: Metadata extraction skipped. No AppIntents.framework dependency found.

GoogleUtilities passed validation.

ncooke3
ncooke3 commented Apr 16, 2026
View reviewed changes
Comment thread GoogleUtilities/SwizzlerTestHelpers/GULRuntimeSnapshot.m
Copy link
Copy Markdown
Member Author

@ncooke3 ncooke3 Apr 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge actions:

  • Merge PR, move tags, stage pod, verify with
pod spec lint GoogleUtilities.podspec --platforms=macos --sources=git@github.com:firebase/SpecsStaging.git,https://cdn.cocoapods.org
  • Then publish

@ncooke3 ncooke3 requested a review from paulb777 April 16, 2026 19:05
ncooke3
ncooke3 commented Apr 16, 2026
View reviewed changes
Comment thread .github/workflows/google-utilities.yml Outdated
@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Apr 16, 2026

One failure for catalyst

Failing tests:
	-[GULMutableDictionaryTest testSessionMapStress]

@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Apr 16, 2026

One failure for catalyst

Failing tests:
	-[GULMutableDictionaryTest testSessionMapStress]

Passed locally. Could be just a flaky test due to the concurrent nature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulb777 paulb777 Awaiting requested review from paulb777

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ncooke3