Fix: reject trailing data after top-level JSON null

[Senrian]

Summary

Fixes #3008

Gson.fromJson(String/Reader, ...) and JsonParser.parseReader(Reader) documentedly reject trailing data, but both made an exception when the parsed top-level value was JSON null.

For non-null values, trailing data already causes a JsonSyntaxException. For top-level null, the trailing-data check was skipped.

Changes

Gson.java

// Before:
if (obj != null && reader.peek() != JsonToken.END_DOCUMENT) {

// After:
if (obj == null || reader.peek() != JsonToken.END_DOCUMENT) {

JsonParser.java

// Before:
if (!element.isJsonNull() && jsonReader.peek() != JsonToken.END_DOCUMENT) {

// After:
if (jsonReader.peek() != JsonToken.END_DOCUMENT) {

Tests

Added testParseTrailingDataAfterNull() and testFromJsonTrailingDataAfterNull() in JsonParserTest.java to verify trailing data is rejected after parsing top-level null.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[Marcono1234]

Please explain how your PR differs from or is better than PR #3008 (which you claim your PR "fixes").

In particular it seems your PR has two problems:

• your change to use obj == null now fails even if JSON null has no trailing data
• your test which excepts JsonParser.parseString("nulltrailing") to fail most likely does not work because Gson instead parses that as unquoted string (I assume)